Cypress refactor #1058
Open
Cypress refactor #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FahadDarw
requested review from
cshnimble,
dneed-nimble,
paullocknimble,
danielryannimble,
dangood84,
nwarms and
elielijah321
as code owners
mikestock-nimble
approved these changes
May 20, 2024
...s/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/application_Form_tests.cy.js
Show resolved
Hide resolved
cshnimble
suggested changes
May 20, 2024
| @@ -17,12 +17,12 @@ | |||
| <div class="govuk-grid-row"> | |||
| <div class="govuk-grid-column-two-thirds"> | |||
| <h2 class="govuk-heading-l govuk-!-margin-bottom govuk-!-font-size-36">School application form</h2> | |||
| <nav class="gem-c-contents-list" aria-label="Pages in this guide" role="navigation" data-module="gem-track-click"> | |||
| <nav class="gem-c-contents-list" aria-label="Pages in this guide" role="navigation" data-module="gem-track-click" data-cy="content-Table"> | |||
There was a problem hiding this comment.
We should probably have some consistency in the tags i.e. all lowercase and using either - or _. I'm not fussy which, but will make it easier to maintain
| it('Should filter and select the project, then verify details of Voluntary', () => { | ||
|
|
||
| // Step 1: Filter search | ||
| applicationFormTaskList.filterSearch('Fahads Cypress Trust'); |
There was a problem hiding this comment.
Maybe just "Cypress Trust"?
There was a problem hiding this comment.
I need it to be Fahads Cypress Trust as Elijah has already created those cases for me. but next time I can try and change the name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Enhanced Cypress Test Suite for "Form a MAT" and "Voluntary Conversion" Projects in School Application Form
Description:
Our Cypress test suite has been significantly enhanced to incorporate additional checks and functionalities for the "Form a MAT" and "Voluntary Conversion" projects. The updates include:
Assignees:
Tags:
Kindly review the updates and proceed with merging the PR if everything aligns with expectations. Your cooperation is highly appreciated!